Skip to content

Commit

Permalink
associate random colours with authors
Browse files Browse the repository at this point in the history
  • Loading branch information
jesseduffield committed Oct 30, 2021
1 parent f704707 commit 253504a
Show file tree
Hide file tree
Showing 5 changed files with 145 additions and 4 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ require (
github.com/konsorten/go-windows-terminal-sequences v1.0.2 // indirect
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/kyokomi/emoji/v2 v2.2.8
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
github.com/lucasb-eyer/go-colorful v1.2.0
github.com/mattn/go-colorable v0.1.7 // indirect
github.com/mattn/go-runewidth v0.0.13 // indirect
github.com/mgutz/str v1.2.0
Expand Down
75 changes: 72 additions & 3 deletions pkg/gui/presentation/commits.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
package presentation

import (
"crypto/md5"
"strings"

"github.com/gookit/color"
"github.com/jesseduffield/lazygit/pkg/commands/models"
"github.com/jesseduffield/lazygit/pkg/gui/style"
"github.com/jesseduffield/lazygit/pkg/theme"
"github.com/jesseduffield/lazygit/pkg/utils"
"github.com/kyokomi/emoji/v2"
colorful "github.com/lucasb-eyer/go-colorful"
)

func GetCommitListDisplayStrings(commits []*models.Commit, fullDescription bool, cherryPickedCommitShaMap map[string]bool, diffName string, parseEmoji bool) [][]string {
Expand Down Expand Up @@ -60,8 +63,6 @@ func getFullDescriptionDisplayStringsForCommit(c *models.Commit, cherryPickedCom
tagString = style.FgMagenta.SetBold().Sprint(c.ExtraInfo) + " "
}

truncatedAuthor := utils.TruncateWithEllipsis(c.Author, 17)

name := c.Name
if parseEmoji {
name = emoji.Sprint(name)
Expand All @@ -70,7 +71,7 @@ func getFullDescriptionDisplayStringsForCommit(c *models.Commit, cherryPickedCom
return []string{
shaColor.Sprint(c.ShortSha()),
secondColumnString,
style.FgYellow.Sprint(truncatedAuthor),
longAuthor(c.Author),
tagString + theme.DefaultTextColor.Sprint(name),
}
}
Expand Down Expand Up @@ -114,10 +115,78 @@ func getDisplayStringsForCommit(c *models.Commit, cherryPickedCommitShaMap map[s

return []string{
shaColor.Sprint(c.ShortSha()),
shortAuthor(c.Author),
actionString + tagString + theme.DefaultTextColor.Sprint(name),
}
}

var authorInitialCache = make(map[string]string)
var authorNameCache = make(map[string]string)

func shortAuthor(authorName string) string {
if _, ok := authorInitialCache[authorName]; ok {
return authorInitialCache[authorName]
}

initials := getInitials(authorName)
if initials == "" {
return ""
}

value := authorColor(authorName).Sprint(initials)
authorInitialCache[authorName] = value

return value
}

func longAuthor(authorName string) string {
if _, ok := authorNameCache[authorName]; ok {
return authorNameCache[authorName]
}

truncatedName := utils.TruncateWithEllipsis(authorName, 17)
value := authorColor(authorName).Sprint(truncatedName)
authorNameCache[authorName] = value

return value
}

func authorColor(authorName string) style.TextStyle {
hash := md5.Sum([]byte(authorName))
c := colorful.Hsl(randFloat(hash[0:4])*360.0, 0.6+0.4*randFloat(hash[4:8]), 0.4+randFloat(hash[8:12])*0.2)

return style.New().SetFg(style.NewRGBColor(color.RGB(uint8(c.R*255), uint8(c.G*255), uint8(c.B*255))))
}

func randFloat(hash []byte) float64 {
sum := 0
for _, b := range hash {
sum = (sum + int(b)) % 100
}
return float64(sum) / 100
}

var authorStyles = []style.TextStyle{
style.FgGreen,
style.FgYellow,
style.FgMagenta,
style.FgCyan,
style.FgRed,
}

func getInitials(authorName string) string {
if authorName == "" {
return authorName
}

split := strings.Split(authorName, " ")
if len(split) == 1 {
return utils.LimitStr(authorName, 2)
}

return split[0][0:1] + split[1][0:1]
}

func actionColorMap(str string) style.TextStyle {
switch str {
case "pick":
Expand Down
17 changes: 17 additions & 0 deletions pkg/gui/presentation/commits_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package presentation

import "testing"

func TestGetInitials(t *testing.T) {
for input, output := range map[string]string{
"Jesse Duffield": "JD",
"Jesse Duffield Man": "JD",
"JesseDuffield": "Je",
"J": "J",
"": "",
} {
if output != getInitials(input) {
t.Errorf("Expected %s to be %s", input, output)
}
}
}
7 changes: 7 additions & 0 deletions pkg/utils/slice.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,10 @@ func Reverse(values []string) []string {
}
return result
}

func LimitStr(value string, limit int) string {
if len(value) > limit {
return value[:limit]
}
return value
}
48 changes: 48 additions & 0 deletions pkg/utils/slice_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,51 @@ func TestReverse(t *testing.T) {
}
}
}

func TestLimitStr(t *testing.T) {
for _, test := range []struct {
values string
limit int
want string
}{
{
values: "",
limit: 10,
want: "",
},
{
values: "",
limit: 0,
want: "",
},
{
values: "a",
limit: 1,
want: "a",
},
{
values: "ab",
limit: 2,
want: "ab",
},
{
values: "abc",
limit: 3,
want: "abc",
},
{
values: "abcd",
limit: 3,
want: "abc",
},
{
values: "abcde",
limit: 3,
want: "abc",
},
} {
if got := LimitStr(test.values, test.limit); !assert.EqualValues(t, got, test.want) {
t.Errorf("LimitString(%v, %d) = %v; want %v", test.values, test.limit, got, test.want)
}
}
}

0 comments on commit 253504a

Please sign in to comment.