Skip to content

Commit

Permalink
More detailed comments for engine build windows VM (flutter#8456)
Browse files Browse the repository at this point in the history
To make it clearer what the next step is after the script run.
  • Loading branch information
liyuqian authored Apr 5, 2019
1 parent 1854b85 commit 08a1335
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion ci/docker/windows_build/prepare_windows_server_2016_core.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,22 @@ mkdir c:/flutter/engine
curl https://raw.githubusercontent.com/flutter/engine/master/ci/docker/build/engine_gclient `
-o c:/flutter/engine/.gclient

# Once all the environment variables above are loaded correctly, one may test
# Once the above script finishes successfully, one can make an image of the VM
# for the CI test.
#
# For sanity check, one can also test the VM to make sure that Flutter engine
# can be built in that VM. (The test is optional and our current image is made
# before doing these tests. We only did a reboot before making that image to
# ensure environment variables are loaded. However, Cirrus CI seems to have
# problems reading those environment variables so we ended up setting them in
# ".cirrus.yml" manually.)
#
# To test, first reboot of the terminal (or VM) to ensure that environment
# variables "path", "DEPOT_TOOLS_WIN_TOOLCHAIN", and "GYP_MSVS_OVERRIDE_PATH"
# are set. (Those environment variables are not needed for Cirrus CI as Cirrus
# sets those environment variables by itself.)
#
# After all the environment variables above are loaded correctly, one may test
# build the engine by:
# cd c:/flutter/engine
# gclient sync
Expand Down

0 comments on commit 08a1335

Please sign in to comment.