Update docs for change to Rap Genius website #45
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Genius website (formerly Rap Genius) changed, which broke the existing documentation example. The search results now include results matching song title as well as artist, making it difficult to guarantee the first song would match the artist being searched for. As a result the example was updated to search for a more unique band name. [Resolves #33]
|
Looks good to me. Thanks for the patch! |
jmcarp
added a commit
that referenced
this pull request
Jun 7, 2015
Update docs for change to Rap Genius website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #33 to account for Genius website change to search and some HTML classes.
I changed the band being searched for to a more unique band name since the Genius website search returns matches by both artist name and song title. This meant when searching for Queen the first 3 songs were by different artists.
Let me know if you'd like to see any revisions to these changes.