Skip to content

Commit

Permalink
fix CODEOWNERS rule that was intended to match dependencies only, not…
Browse files Browse the repository at this point in the history 
… tests (apache#6340)

* fixed CODEOWNERS rule that incorrectly included some tests but was intended to match dependencies only
* brought stray management and session tests under the correct umbrella
* brought stray test utils under the correct umbrella
* brought stray wan and persistence tests under the correct umbrella
* brought stray sni and launcher tests under the correct umbrella
* brought stray pulse, logging, and metrics tests under the correct umbrella
* brought stray gfsh and packaging tests under the correct umbrella
* internal/cache/client should have been cache/client/internal (already covered by cache/client/**) so removed
* removed k from docs watchers, moved metatype to watchers, cleaned up whitespace
* fixed typos in rules that didn't match any files at all
  • Loading branch information
@onichols-pivotal
onichols-pivotal authored Apr 22, 2021
1 parent e933b51 commit 78598cf
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 12 deletions.
31 changes: 24 additions & 7 deletions CODEOWNERS
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# CODEOWNERS and .asf.yml - ownerless so everyone "owns" it
#-----------------------------------------------------------------
#CODEOWNERS
#.asf.yml
#.asf.yaml

#-----------------------------------------------------------------
# Serialization
Expand Down Expand Up @@ -50,14 +50,15 @@ geode-core/**/org/apache/geode/distributed/internal/* @echobravopapa
#-----------------------------------------------------------------
geode-core/**/org/apache/geode/cache/client/** @echobravopapa @Bill @kirklund
geode-core/**/org/apache/geode/cache/server/** @echobravopapa @Bill @kirklund
geode-core/**/org/apache/geode/internal/cache/client/** @Bill @echobravopapa
geode-core/**/org/apache/geode/cache/client/internal/** @Bill @echobravopapa
geode-core/**/org/apache/geode/internal/cache/tier/** @Bill @echobravopapa @agingade
geode-assembly/**/apache/geode/client/sni/** @Bill @echobravopapa

#-----------------------------------------------------------------
# Client Queues
#-----------------------------------------------------------------
geode-core/**/org/apache/geode/internal/cache/ha/** @agingade @boglesby @nabarunnag
geode-core/**/org/apache/geode/internal/cache/tier/CacheClient* @agingade @boglesby @nabarunnag
geode-core/**/org/apache/geode/internal/cache/**/CacheClient* @agingade @boglesby @nabarunnag

#-----------------------------------------------------------------
# Core Public API packages - Cache, Region, etc.
Expand Down Expand Up @@ -132,11 +133,13 @@ geode-core/**/org/apache/geode/cache/query/** @nabarunnag @D
#-----------------------------------------------------------------
extensions/** @sabbey37 @jdeppe-pivotal @BenjaminPerryRoss
geode-core/**/org/apache/geode/internal/modules/util/** @sabbey37 @jdeppe-pivotal @BenjaminPerryRoss
geode-assembly/**/org/apache/geode/session/** @sabbey37 @jdeppe-pivotal @BenjaminPerryRoss

#-----------------------------------------------------------------
# DEV rest API
#-----------------------------------------------------------------
geode-web-api/** @jdeppe-pivotal @jinmeiliao
geode-assembly/**/org/apache/geode/rest/** @jdeppe-pivotal @jinmeiliao

#-----------------------------------------------------------------
# Lucene integration
Expand Down Expand Up @@ -173,6 +176,7 @@ geode-unsafe/** @nabarunnag @b
geode-core/**/org/apache/geode/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou
geode-core/**/org/apache/geode/internal/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou
geode-core/**/org/apache/geode/internal/cache/backup/** @dschneider-pivotal @agingade @jchen21 @upthewaterspout @gesterzhou
geode-assembly/**/org/apache/geode/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou

#-----------------------------------------------------------------
# Region Version Vectors - used for sychronization on
Expand All @@ -187,13 +191,17 @@ geode-wan/** @gesterzhou @b
geode-core/**/org/apache/geode/cache/asyncqueue/** @gesterzhou @boglesby @nabarunnag
geode-core/**/org/apache/geode/cache/wan/** @gesterzhou @boglesby @nabarunnag
geode-core/**/org/apache/geode/internal/cache/wan/** @gesterzhou @boglesby @nabarunnag
geode-assembly/**/apache/geode/cache/wan/** @gesterzhou @boglesby @nabarunnag

#-----------------------------------------------------------------
# Management
#-----------------------------------------------------------------
geode-management/** @jdeppe-pivotal @jinmeiliao
geode-assembly/**/org/apache/geode/management/** @jdeppe-pivotal @jinmeiliao
geode-assembly/**/org/apache/geode/tools/pulse/** @jdeppe-pivotal @jinmeiliao
geode-web-management/** @jdeppe-pivotal @jinmeiliao
geode-gfsh/** @jdeppe-pivotal @jinmeiliao @mhansonp @kirklund
geode-assembly/**/bin/** @jdeppe-pivotal @jinmeiliao @mhansonp @kirklund
geode-pulse/** @jdeppe-pivotal @jinmeiliao @mhansonp
geode-http-service/** @jdeppe-pivotal @jinmeiliao
geode-web/** @jdeppe-pivotal @jinmeiliao
Expand All @@ -217,6 +225,7 @@ geode-core/**/org/apache/geode/security/** @jdeppe-pivota
geode-core/**/org/apache/geode/internal/security/** @jdeppe-pivotal @jinmeiliao
geode-core/**/org/apache/geode/cache/operations/** @jdeppe-pivotal @jinmeiliao
geode-core/**/org/apache/geode/internal/cache/operations/** @jdeppe-pivotal @jinmeiliao
geode-assembly/**/apache/geode/ssl/** @jdeppe-pivotal @jinmeiliao

#-----------------------------------------------------------------
# Logging
Expand All @@ -228,13 +237,15 @@ geode-core/**/org/apache/geode/internal/logging/** @mhansonp @kir
geode-core/**/org/apache/geode/i18n/** @agingade @kirklund
geode-core/**/org/apache/geode/internal/i18n/** @agingade @kirklund
geode-core/**/org/apache/geode/internal/io/** @agingade @kirklund
geode-assembly/**/org/apache/geode/logging/** @agingade @kirklund

#-----------------------------------------------------------------
# Metrics & Statistics
#-----------------------------------------------------------------
geode-core/**/org/apache/geode/internal/statistics/** @mhansonp @kirklund
geode-core/**/org/apache/geode/internal/stats50/** @mhansonp @kirklund
geode-core/**/org/apache/geode/metrics/** @mhansonp @kirklund
geode-assembly/**/org/apache/geode/metrics/** @mhansonp @kirklund

#-----------------------------------------------------------------
# Region Snapshots
Expand Down Expand Up @@ -262,7 +273,10 @@ geode-core/**/org/apache/geode/internal/cache/control/** @kirklund @Don
geode-dunit/** @mhansonp @kirklund
geode-junit/** @mhansonp @kirklund
#geode-jmh/**
geode-junit/**/org/apache/geode/test/util @jdeppe-pivotal @onichols-pivotal
geode-junit/**/org/apache/geode/test/util/** @jdeppe-pivotal @onichols-pivotal
geode-assembly/**/org/apache/geode/test/junit/** @jdeppe-pivotal @jinmeiliao
geode-assembly/**/org/apache/geode/launchers/** @dschneider-pivotal @boglesby @kirklund @nabarunnag
geode-assembly/**/resources/** @boglesby @kirklund @nabarunnag @jdeppe-pivotal @jinmeiliao

#-----------------------------------------------------------------
# Redis API
Expand All @@ -286,14 +300,17 @@ geode-management/src/test/script/update-management-wiki.sh @onichols-pivo
static-analysis/** @rhoughton-pivot @onichols-pivotal
geode-old-versions/** @onichols-pivotal @dickcav
KEYS @onichols-pivotal @dickcav
geode-assembly/** @rhoughton-pivot @onichols-pivotal
geode-assembly/**/org/apache/geode/** @rhoughton-pivot @onichols-pivotal @dickcav
assembly_content.txt @rhoughton-pivot @onichols-pivotal
dependency_classpath.txt @rhoughton-pivot @onichols-pivotal
expected-pom.xml @rhoughton-pivot @onichols-pivotal

#-----------------------------------------------------------------
# Documentation
#-----------------------------------------------------------------
BUILDING.md @rhoughton-pivot @upthewaterspout
CODE_OF_CONDUCT.md @upthewaterspout @pivotal-amurmann @nonbinaryprogrammer
LICENSE @onichols-pivotal @dickcav @metatype
NOTICE @onichols-pivotal @dickcav @metatype
LICENSE @onichols-pivotal @dickcav
NOTICE @onichols-pivotal @dickcav
/README.md @upthewaterspout @pivotal-amurmann
#TESTING.md
11 changes: 6 additions & 5 deletions CODEWATCHERS
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.


# This file follows the same format as CODEOWNERS, but adds you as
# This file follows the same format as CODEOWNERS, but adds you as
# an optional reviewer rather than a required code owner reviewer.


Expand All @@ -24,16 +24,18 @@
#-----------------------------------------------------------------
CODEOWNERS @onichols-pivotal @rhoughton-pivot
CODEWATCHERS @onichols-pivotal @rhoughton-pivot
.asf.yml @onichols-pivotal @rhoughton-pivot
.asf.yaml @onichols-pivotal @rhoughton-pivot


#-----------------------------------------------------------------
# Documentation
#-----------------------------------------------------------------
geode-book/** @karensmolermiller @davebarnes97
geode-docs/** @karensmolermiller @davebarnes97
geode-book/** @davebarnes97
geode-docs/** @davebarnes97
geode-book/config.yml @onichols-pivotal
geode-book/redirects.rb @onichols-pivotal
LICENSE @metatype
NOTICE @metatype

#-----------------------------------------------------------------
# Jar Deployment
Expand All @@ -51,7 +53,6 @@ geode-core/**/org/apache/geode/cache/internal/execute/* @kohlmu-pivota
#-----------------------------------------------------------------
geode-core/**/org/apache/geode/cache/client/** @albertogpz
geode-core/**/org/apache/geode/cache/server/** @albertogpz
geode-core/**/org/apache/geode/internal/cache/client/** @albertogpz
geode-core/**/org/apache/geode/internal/cache/tier/** @albertogpz


Expand Down

0 comments on commit 78598cf

Please sign in to comment.