Skip to content

Commit

Permalink
GEODE-9977: Remove defunct RedisCommandSupportLevel.INTERNAL type (ap…
Browse files Browse the repository at this point in the history
…ache#7283)

Authored-by: Donal Evans <[email protected]>
  • Loading branch information
DonalEvans authored Jan 20, 2022
1 parent dccfc18 commit b349cb8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@
public enum RedisCommandSupportLevel {
SUPPORTED,
UNSUPPORTED,
UNKNOWN,
INTERNAL
UNKNOWN
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package org.apache.geode.redis.internal.commands;

import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX;
import static org.apache.geode.redis.internal.commands.RedisCommandSupportLevel.INTERNAL;
import static org.apache.geode.redis.internal.commands.RedisCommandSupportLevel.SUPPORTED;
import static org.apache.geode.redis.internal.commands.RedisCommandSupportLevel.UNSUPPORTED;
import static org.apache.geode.redis.internal.commands.RedisCommandType.Flag.ADMIN;
Expand Down Expand Up @@ -447,11 +446,6 @@ public boolean isUnsupported() {
return supportLevel == UNSUPPORTED;
}


public boolean isInternal() {
return supportLevel == INTERNAL;
}

public boolean isUnknown() {
return supportLevel == RedisCommandSupportLevel.UNKNOWN;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ private RedisResponse executeNoSubcommand(ExecutionHandlerContext context) {
List<Object> response = new ArrayList<>();

for (RedisCommandType type : RedisCommandType.values()) {
if (type.isInternal()
|| type.isUnknown()
if (type.isUnknown()
|| (type.isUnsupported() && !context.allowUnsupportedCommands())
|| type == RedisCommandType.QUIT) {
continue;
Expand Down

0 comments on commit b349cb8

Please sign in to comment.