Additional testing for reflectx package #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change the functionality of the reflectx package -- it just contains additional tests. I'm thinking of submitting a PR in future, and I figured one good way to get more familiar with the workings would be to write some tests for the untested bits.
Before and after coverage stats are listed below. You can see that we have gone from 83% coverage to 99.3%.
Coverage would be 100%, except for one stubborn little line in
methodName()
. Test coverage on that line would either require modifyingreflect.go
or somehow tricking the runtime into thinking a PC value was not valid. I didn't want to modifyreflect.go
in this PR, and fiddling with the runtime seemed a little obsessive for one little line of code, so it stays untested for now.Before
After: