Add testonly = true to the flutter/testing target and disable WTF tes…

…ts that depend on ICU. (flutter#3271)
jnuhwb · Nov 24, 2016 · 55ed560 · 55ed560
1 parent c4bd577
commit 55ed560
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/sky/engine/wtf/BUILD.gn b/sky/engine/wtf/BUILD.gn
@@ -237,10 +237,13 @@ executable("wtf_unittests") {
     "text/StringBuilderTest.cpp",
     "text/StringImplTest.cpp",
     "text/StringOperatorsTest.cpp",
-    "text/TextCodecReplacementTest.cpp",
     "text/TextCodecUTF8Test.cpp",
-    "text/WTFStringTest.cpp",
     "VectorTest.cpp",
+
+    # The following tests depend on either ICU or the locale. Disable them for
+    # now.
+    # "text/TextCodecReplacementTest.cpp",
+    # "text/WTFStringTest.cpp",
   ]
 
   configs += [

diff --git a/synchronization/BUILD.gn b/synchronization/BUILD.gn
@@ -18,6 +18,8 @@ source_set("synchronization") {
 }
 
 executable("synchronization_unittests") {
+  testonly = true
+
   sources = [
     "semaphore_unittest.cc",
   ]

diff --git a/testing/BUILD.gn b/testing/BUILD.gn
@@ -3,6 +3,8 @@
 # found in the LICENSE file.
 
 source_set("testing") {
+  testonly = true
+
   sources = [
     "//flutter/testing/run_all_unittests.cc",
   ]