Skip to content

Commit

Permalink
Fix OSS build failure due to approx sgd (pytorch#570)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#570

Resolve OSS failure:
```
======================================================================
ERROR: test_backward_sgd (__main__.SplitTableBatchedEmbeddingsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/split_table_batched_embeddings_test.py", line 444, in test_backward_sgd
    T=st.integers(min_value=1, max_value=5),
  File "/home/jianyuhuang/miniconda3/lib/python3.7/site-packages/hypothesis/core.py", line 1162, in wrapped_test
    raise the_error_hypothesis_found
  File "test/split_table_batched_embeddings_test.py", line 615, in test_backward_sgd
    if not weighted
  File "/home/jianyuhuang/miniconda3/lib/python3.7/site-packages/torch/nn/modules/module.py", line 879, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/jianyuhuang/Work/Github/FBGEMM/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops.py", line 503, in forward
    return invokers.lookup_approx_sgd.invoke(common_args, self.optimizer_args)
AttributeError: module 'fbgemm_gpu.split_embedding_codegen_lookup_invokers' has no attribute 'lookup_approx_sgd'
```

Reviewed By: jspark1105

Differential Revision: D27245407

fbshipit-source-id: 53a1e7cbc3b68934f37904eebae87437b71b47cf
  • Loading branch information
jianyuh authored and facebook-github-bot committed Mar 23, 2021
1 parent 3657619 commit 28b130f
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@
import python.lookup_partial_rowwise_lamb as lookup_partial_rowwise_lamb # noqa: F401
import python.lookup_rowwise_adagrad as lookup_rowwise_adagrad # noqa: F401
import python.lookup_sgd as lookup_sgd # noqa: F401
import python.lookup_approx_sgd as lookup_approx_sgd # noqa: F401

0 comments on commit 28b130f

Please sign in to comment.