Skip to content

Commit

Permalink
cleanup temp interface (pytorch#435)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#435

As title

Reviewed By: dskhudia

Differential Revision: D24197727

fbshipit-source-id: b660276060ae3250ac5a6844a2b7551797fd1cf0
  • Loading branch information
jspark1105 authored and facebook-github-bot committed Oct 11, 2020
1 parent 75ea7ce commit da05c8d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
8 changes: 0 additions & 8 deletions include/fbgemm/FbgemmEmbedding.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,6 @@ GenerateSparseAdaGrad(
int prefetch = 16,
bool use_weight_decay = false);

template <typename IndexType>
FBGEMM_API typename SparseAdaGradSignature<IndexType>::NewType
GenerateSparseAdaGradNew(
int block_size, // number of parameters per row
bool rowwise = false,
int prefetch = 16,
bool use_weight_decay = false);

// RowWiseSparseAdaGrad fused with SLS gradient
// Weights can be either float or float16
template <
Expand Down
24 changes: 0 additions & 24 deletions src/SparseAdagrad.cc
Original file line number Diff line number Diff line change
Expand Up @@ -912,28 +912,4 @@ GenerateSparseAdaGrad<std::int32_t>(
int prefetch,
bool use_weight_decay);

template <typename IndexType>
typename SparseAdaGradSignature<IndexType>::NewType GenerateSparseAdaGradNew(
int block_size,
bool rowwise,
int prefetch,
bool use_weight_decay) {
return GenerateSparseAdaGrad<IndexType>(
block_size, rowwise, prefetch, use_weight_decay);
}

template FBGEMM_API typename SparseAdaGradSignature<std::int64_t>::NewType
GenerateSparseAdaGradNew<std::int64_t>(
int block_size, // number of parameters per rows
bool rowwise,
int prefetch,
bool use_weight_decay);

template FBGEMM_API typename SparseAdaGradSignature<std::int32_t>::NewType
GenerateSparseAdaGradNew<std::int32_t>(
int block_size, // number of parameters per rows
bool rowwise,
int prefetch,
bool use_weight_decay);

} // namespace fbgemm

0 comments on commit da05c8d

Please sign in to comment.