Skip to content

Commit

Permalink
[PATCH] 64bit resource: fix up printks for resources in sound drivers
Browse files Browse the repository at this point in the history
This is needed if we wish to change the size of the resource structures.

Based on an original patch from Vivek Goyal <[email protected]>

Cc: Vivek Goyal <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Jun 27, 2006
1 parent 740e518 commit aa0a2dd
Show file tree
Hide file tree
Showing 11 changed files with 34 additions and 26 deletions.
5 changes: 3 additions & 2 deletions sound/arm/aaci.c
Original file line number Diff line number Diff line change
Expand Up @@ -779,8 +779,9 @@ static struct aaci * __devinit aaci_init_card(struct amba_device *dev)
strlcpy(card->driver, DRIVER_NAME, sizeof(card->driver));
strlcpy(card->shortname, "ARM AC'97 Interface", sizeof(card->shortname));
snprintf(card->longname, sizeof(card->longname),
"%s at 0x%08lx, irq %d",
card->shortname, dev->res.start, dev->irq[0]);
"%s at 0x%016llx, irq %d",
card->shortname, (unsigned long long)dev->res.start,
dev->irq[0]);

aaci = card->private_data;
mutex_init(&aaci->ac97_sem);
Expand Down
5 changes: 3 additions & 2 deletions sound/drivers/mpu401/mpu401.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,9 @@ static int __devinit snd_mpu401_pnp(int dev, struct pnp_dev *device,
return -ENODEV;
}
if (pnp_port_len(device, 0) < IO_EXTENT) {
snd_printk(KERN_ERR "PnP port length is %ld, expected %d\n",
pnp_port_len(device, 0), IO_EXTENT);
snd_printk(KERN_ERR "PnP port length is %llu, expected %d\n",
(unsigned long long)pnp_port_len(device, 0),
IO_EXTENT);
return -ENODEV;
}
port[dev] = pnp_port_start(device, 0);
Expand Down
3 changes: 2 additions & 1 deletion sound/isa/es18xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2088,7 +2088,8 @@ static int __devinit snd_audiodrive_pnp(int dev, struct snd_audiodrive *acard,
kfree(cfg);
return -EAGAIN;
}
snd_printdd("pnp: port=0x%lx\n", pnp_port_start(acard->devc, 0));
snd_printdd("pnp: port=0x%llx\n",
(unsigned long long)pnp_port_start(acard->devc, 0));
/* PnP initialization */
pdev = acard->dev;
pnp_init_resource_table(cfg);
Expand Down
8 changes: 4 additions & 4 deletions sound/isa/gus/interwave.c
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,10 @@ static int __devinit snd_interwave_pnp(int dev, struct snd_interwave *iwcard,
if (dma2[dev] >= 0)
dma2[dev] = pnp_dma(pdev, 1);
irq[dev] = pnp_irq(pdev, 0);
snd_printdd("isapnp IW: sb port=0x%lx, gf1 port=0x%lx, codec port=0x%lx\n",
pnp_port_start(pdev, 0),
pnp_port_start(pdev, 1),
pnp_port_start(pdev, 2));
snd_printdd("isapnp IW: sb port=0x%llx, gf1 port=0x%llx, codec port=0x%llx\n",
(unsigned long long)pnp_port_start(pdev, 0),
(unsigned long long)pnp_port_start(pdev, 1),
(unsigned long long)pnp_port_start(pdev, 2));
snd_printdd("isapnp IW: dma1=%i, dma2=%i, irq=%i\n", dma1[dev], dma2[dev], irq[dev]);
#ifdef SNDRV_STB
/* Tone Control initialization */
Expand Down
3 changes: 2 additions & 1 deletion sound/isa/sb/sb16.c
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ static int __devinit snd_card_sb16_pnp(int dev, struct snd_card_sb16 *acard,
goto __wt_error;
}
awe_port[dev] = pnp_port_start(pdev, 0);
snd_printdd("pnp SB16: wavetable port=0x%lx\n", pnp_port_start(pdev, 0));
snd_printdd("pnp SB16: wavetable port=0x%llx\n",
(unsigned long long)pnp_port_start(pdev, 0));
} else {
__wt_error:
if (pdev) {
Expand Down
5 changes: 3 additions & 2 deletions sound/oss/forte.c
Original file line number Diff line number Diff line change
Expand Up @@ -2035,8 +2035,9 @@ forte_probe (struct pci_dev *pci_dev, const struct pci_device_id *pci_id)

pci_set_drvdata (pci_dev, chip);

printk (KERN_INFO PFX "FM801 chip found at 0x%04lX-0x%04lX IRQ %u\n",
chip->iobase, pci_resource_end (pci_dev, 0), chip->irq);
printk (KERN_INFO PFX "FM801 chip found at 0x%04lX-0x%16llX IRQ %u\n",
chip->iobase, (unsigned long long)pci_resource_end (pci_dev, 0),
chip->irq);

/* Power it up */
if ((ret = forte_chip_init (chip)) == 0)
Expand Down
5 changes: 3 additions & 2 deletions sound/pci/bt87x.c
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,9 @@ static int __devinit snd_bt87x_probe(struct pci_dev *pci,

strcpy(card->driver, "Bt87x");
sprintf(card->shortname, "Brooktree Bt%x", pci->device);
sprintf(card->longname, "%s at %#lx, irq %i",
card->shortname, pci_resource_start(pci, 0), chip->irq);
sprintf(card->longname, "%s at %#llx, irq %i",
card->shortname, (unsigned long long)pci_resource_start(pci, 0),
chip->irq);
strcpy(card->mixername, "Bt87x");

err = snd_card_register(card);
Expand Down
4 changes: 2 additions & 2 deletions sound/pci/sonicvibes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1441,10 +1441,10 @@ static int __devinit snd_sonic_probe(struct pci_dev *pci,

strcpy(card->driver, "SonicVibes");
strcpy(card->shortname, "S3 SonicVibes");
sprintf(card->longname, "%s rev %i at 0x%lx, irq %i",
sprintf(card->longname, "%s rev %i at 0x%llx, irq %i",
card->shortname,
sonic->revision,
pci_resource_start(pci, 1),
(unsigned long long)pci_resource_start(pci, 1),
sonic->irq);

if ((err = snd_sonicvibes_pcm(sonic, 0, NULL)) < 0) {
Expand Down
14 changes: 8 additions & 6 deletions sound/ppc/pmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1170,9 +1170,10 @@ int __init snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
chip->rsrc[i].start + 1,
rnames[i]) == NULL) {
printk(KERN_ERR "snd: can't request rsrc "
" %d (%s: 0x%08lx:%08lx)\n",
i, rnames[i], chip->rsrc[i].start,
chip->rsrc[i].end);
" %d (%s: 0x%016lx:%016lx)\n",
i, rnames[i],
(unsigned long long)chip->rsrc[i].start,
(unsigned long long)chip->rsrc[i].end);
err = -ENODEV;
goto __error;
}
Expand Down Expand Up @@ -1201,9 +1202,10 @@ int __init snd_pmac_new(struct snd_card *card, struct snd_pmac **chip_return)
chip->rsrc[i].start + 1,
rnames[i]) == NULL) {
printk(KERN_ERR "snd: can't request rsrc "
" %d (%s: 0x%08lx:%08lx)\n",
i, rnames[i], chip->rsrc[i].start,
chip->rsrc[i].end);
" %d (%s: 0x%016llx:%016llx)\n",
i, rnames[i],
(unsigned long long)chip->rsrc[i].start,
(unsigned long long)chip->rsrc[i].end);
err = -ENODEV;
goto __error;
}
Expand Down
4 changes: 2 additions & 2 deletions sound/sparc/cs4231.c
Original file line number Diff line number Diff line change
Expand Up @@ -2037,10 +2037,10 @@ static int __init cs4231_sbus_attach(struct sbus_dev *sdev)
if (err)
return err;

sprintf(card->longname, "%s at 0x%02lx:0x%08lx, irq %d",
sprintf(card->longname, "%s at 0x%02lx:0x%016lx, irq %d",
card->shortname,
rp->flags & 0xffL,
rp->start,
(unsigned long long)rp->start,
sdev->irqs[0]);

if ((err = snd_cs4231_sbus_create(card, sdev, dev, &cp)) < 0) {
Expand Down
4 changes: 2 additions & 2 deletions sound/sparc/dbri.c
Original file line number Diff line number Diff line change
Expand Up @@ -2645,9 +2645,9 @@ static int __init dbri_attach(int prom_node, struct sbus_dev *sdev)
strcpy(card->driver, "DBRI");
strcpy(card->shortname, "Sun DBRI");
rp = &sdev->resource[0];
sprintf(card->longname, "%s at 0x%02lx:0x%08lx, irq %d",
sprintf(card->longname, "%s at 0x%02lx:0x%016lx, irq %d",
card->shortname,
rp->flags & 0xffL, rp->start, irq.pri);
rp->flags & 0xffL, (unsigned long long)rp->start, irq.pri);

if ((err = snd_dbri_create(card, sdev, &irq, dev)) < 0) {
snd_card_free(card);
Expand Down

0 comments on commit aa0a2dd

Please sign in to comment.