Skip to content

Commit

Permalink
Pass build type to Impala LZO.
Browse files Browse the repository at this point in the history
Before, the build type used for Impala LZO was always debug.
Now, the build type is passed from the Impala CMakeLists.txt.

This patch needs corresponding changes to Impala LZO.

Testing: I tested locally with these build types:
DEBUG, RELEASE, and ADDRESS_SANITIZER.

Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Reviewed-on: http://gerrit.cloudera.org:8080/6446
Reviewed-by: Alex Behm <[email protected]>
Tested-by: Alex Behm <[email protected]>
  • Loading branch information
Alex Behm authored and jenkins committed Mar 31, 2017
1 parent 024410c commit 518bc04
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ add_custom_target(cscope ALL

if (DEFINED ENV{IMPALA_LZO} AND EXISTS $ENV{IMPALA_LZO})
add_custom_target(impala-lzo ALL DEPENDS thrift-deps
COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_SOURCE_DIR} $ENV{IMPALA_TOOLCHAIN}
COMMAND $ENV{IMPALA_LZO}/build.sh ${CMAKE_BUILD_TYPE} ${CMAKE_SOURCE_DIR}
$ENV{IMPALA_TOOLCHAIN}
)
endif()

Expand Down

0 comments on commit 518bc04

Please sign in to comment.