Skip to content

Commit

Permalink
IMPALA-4259: build Impala without any test cluster setup.
Browse files Browse the repository at this point in the history
The main outcome of this change is to avoid making unnecessary
modification to the Impala or other source trees when we don't need the
test cluster.

To achieve that, this refactors the script to make the flow easier
to understand and makes it more consistent which build steps are
executed in which modes.

Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Reviewed-on: http://gerrit.cloudera.org:8080/4685
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Internal Jenkins
  • Loading branch information
timarmstrong authored and aphadke committed Oct 13, 2016
1 parent 637627c commit a1382ec
Show file tree
Hide file tree
Showing 4 changed files with 176 additions and 158 deletions.
7 changes: 1 addition & 6 deletions bin/clean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ trap 'echo Error in $0 at line $LINENO: $(cd "'$PWD'" && awk "NR == $LINENO" $0)

# If the project was never build, no Makefile will exist and thus make clean will fail.
# Combine the make command with the bash noop to always return true.
make clean || :

# Stop the minikdc if needed.
if "${CLUSTER_DIR}/admin" is_kerberized; then
"${IMPALA_HOME}/testdata/bin/minikdc.sh" stop
fi
"${MAKE_CMD:-make}" clean || :

# clean the external data source project
pushd ${IMPALA_HOME}/ext-data-source
Expand Down
Loading

0 comments on commit a1382ec

Please sign in to comment.