Skip to content

Commit

Permalink
openrisc: Define __ro_after_init to avoid crash
Browse files Browse the repository at this point in the history 
openrisc qemu tests fail with the following crash.

Unable to handle kernel access at virtual address 0xc0300c34

Oops#: 0001
CPU #: 0
   PC: c016c710    SR: 0000ae67    SP: c1017e04
   GPR00: 00000000 GPR01: c1017e04 GPR02: c0300c34 GPR03: c0300c34
   GPR04: 00000000 GPR05: c0300cb0 GPR06: c0300c34 GPR07: 000000ff
   GPR08: c107f074 GPR09: c0199ef4 GPR10: c1016000 GPR11: 00000000
   GPR12: 00000000 GPR13: c107f044 GPR14: c0473774 GPR15: 07ce0000
   GPR16: 00000000 GPR17: c107ed8a GPR18: 00009600 GPR19: c107f044
   GPR20: c107ee74 GPR21: 00000003 GPR22: c0473770 GPR23: 00000033
   GPR24: 000000bf GPR25: 00000019 GPR26: c046400c GPR27: 00000001
   GPR28: c0464028 GPR29: c1018000 GPR30: 00000006 GPR31: ccf37483
     RES: 00000000 oGPR11: ffffffff
     Process swapper (pid: 1, stackpage=c1001960)

     Stack: Stack dump [0xc1017cf8]:
     sp + 00: 0xc1017e04
     sp + 04: 0xc0300c34
     sp + 08: 0xc0300c34
     sp + 12: 0x00000000
...

Bisect points to commit d2ec3f7 ("pty: make ptmx file ops read-only
after init"). Fix by defining __ro_after_init for the openrisc
architecture, similar to parisc.

Fixes: d2ec3f7 ("pty: make ptmx file ops read-only after init")
Cc: Kees Cook <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
Acked-by: Stafford Horne <[email protected]>
  • Loading branch information
@groeck
groeck committed Nov 6, 2016
1 parent bc33b0c commit 2c7a5c5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/openrisc/include/asm/cache.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
* they shouldn't be hard-coded!
*/

#define __ro_after_init __read_mostly

#define L1_CACHE_BYTES 16
#define L1_CACHE_SHIFT 4

Expand Down

0 comments on commit 2c7a5c5

Please sign in to comment.