Skip to content

Commit

Permalink
net: sctp: Rename fallthrough label to unhandled
Browse files Browse the repository at this point in the history
fallthrough will become a pseudo reserved keyword so this only use of
fallthrough is better renamed to allow it.

Signed-off-by: Joe Perches <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Reviewed-by: Kees Cook <[email protected]>
Acked-by: Neil Horman <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
JoePerches authored and torvalds committed Oct 11, 2019
1 parent 9892f9f commit 48f9bcf
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions net/sctp/sm_make_chunk.c
Original file line number Diff line number Diff line change
Expand Up @@ -2155,7 +2155,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
case SCTP_PARAM_SET_PRIMARY:
if (ep->asconf_enable)
break;
goto fallthrough;
goto unhandled;

case SCTP_PARAM_HOST_NAME_ADDRESS:
/* Tell the peer, we won't support this param. */
Expand All @@ -2166,11 +2166,11 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
case SCTP_PARAM_FWD_TSN_SUPPORT:
if (ep->prsctp_enable)
break;
goto fallthrough;
goto unhandled;

case SCTP_PARAM_RANDOM:
if (!ep->auth_enable)
goto fallthrough;
goto unhandled;

/* SCTP-AUTH: Secion 6.1
* If the random number is not 32 byte long the association
Expand All @@ -2187,7 +2187,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,

case SCTP_PARAM_CHUNKS:
if (!ep->auth_enable)
goto fallthrough;
goto unhandled;

/* SCTP-AUTH: Section 3.2
* The CHUNKS parameter MUST be included once in the INIT or
Expand All @@ -2203,7 +2203,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,

case SCTP_PARAM_HMAC_ALGO:
if (!ep->auth_enable)
goto fallthrough;
goto unhandled;

hmacs = (struct sctp_hmac_algo_param *)param.p;
n_elt = (ntohs(param.p->length) -
Expand All @@ -2226,7 +2226,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net,
retval = SCTP_IERROR_ABORT;
}
break;
fallthrough:
unhandled:
default:
pr_debug("%s: unrecognized param:%d for chunk:%d\n",
__func__, ntohs(param.p->type), cid);
Expand Down

0 comments on commit 48f9bcf

Please sign in to comment.