Skip to content

Commit

Permalink
merge-recursive: switch from (oid,mode) pairs to a diff_filespec
Browse files Browse the repository at this point in the history
There was a significant inconsistency in the various parts of the API
used in merge-recursive; many places used a pair of (oid, mode) to track
file version/contents, while other parts used a diff_filespec (which
have an oid and mode embedded in it).  This inconsistency caused lots of
places to need to pack and unpack data to call into other functions.
This has been the subject of some past cleanups (see e.g. commit
0270a07 ("merge-recursive: remove final remaining caller of
merge_file_one()", 2018-09-19)), but let's just remove the underlying
mess altogether by switching to use diff_filespec.

Signed-off-by: Elijah Newren <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
newren authored and gitster committed Apr 8, 2019
1 parent e2d563d commit 8daec1d
Showing 1 changed file with 215 additions and 268 deletions.
Loading

0 comments on commit 8daec1d

Please sign in to comment.