Fixes for no-shadowed-variable rule (palantir#1482)

src/rules/noShadowedVariableRule.ts

@@ -79,6 +79,14 @@ class NoShadowedVariableWalker extends Lint.BlockScopeAwareRuleWalker<ScopeInfo,
         // don't call super, we don't need to check names in function types
     }
 
+    public visitConstructorType(node: ts.FunctionOrConstructorTypeNode) {
+        // don't call super, we don't need to check names in constructor types
+    }
+
+    public visitIndexSignatureDeclaration(node: ts.SignatureDeclaration) {
+        // don't call super, we don't want to walk index signatures
+    }
+
     public visitMethodSignature(node: ts.SignatureDeclaration) {
         // don't call super, we don't want to walk method signatures either
     }

test/rules/no-shadowed-variable/test.ts.lint

@@ -161,3 +161,54 @@ function testParameterDestructuring(
 function testSimpleBlockVar() {
     const simpleBlockVar = 4
 }
+
+interface SeparateIndexeSighatures1 {
+    [separate: string]: any;
+}
+interface SeparateIndexeSighatures2 {
+    [separate: number]: any;
+}
+
+const external = 1;
+interface ExternalIndexSignature1 {
+    [external: string]: any;
+}
+interface ExternalIndexSignature2 {
+    [external: number]: any;
+}
+
+interface CombinedIndexeSighatures {
+    [i: string]: any;
+    [i: number]: any;
+}
+
+function constructorsWithArgs(
+    derivedCtor: new (...args: any[]) => any,
+    baseCtors: Array<new (...args: any[]) => any>): void {
+    // ...
+}
+
+function constructorsWithArgsConst(
+    derivedCtor: new (...args: any[]) => any,
+    baseCtors: Array<new (...args: any[]) => any>): void {
+    const args = [];
+}
+
+function constructorsWithArgsParamConst(
+    derivedCtor: new (...args: any[]) => any,
+    baseCtors: Array<new (...args: any[]) => any>,
+    args: any[]): void {
+    const args = [];
+          ~~~~       [Shadowed variable: 'args']
+}
+
+class MyClass { };
+
+declare type MyConstructor = new (myVariable: any) => MyClass;
+declare type MyFunction = (myParameter: any) => boolean;
+
+function creatorFunction(constructor: MyConstructor, filter: MyFunction): void {
+    const myVariable = 1;
+    const myParameter = 1;
+    console.log(myVariable);
+}