-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D solid model operations #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new dependency on the `manifold3d` library and reintroduces a hard dependency on `scipy`.
81ecd99
to
5f785e4
Compare
Signed-off-by: Jonathan Hogg <[email protected]>
Adds a couple more dependencies, sadly. Also refactoring to simplify 3D model management code.
Also up the default number of segments in the primitive models to 64. Default smooth shading angle to 0.05 (18°), which seems to generally work for most of my examples.
Also, break-up the description of the 3D rendering into a sub-list as it's become unwieldy.
This is neater and more orthogonal. Also allowing `position`, `size` and `rotation` attributes on any model node. Renaming slice origin to `origin` to avoid a clash.
Slicing with a plane doesn't seem to like complex objects, so if `!slice` is given a bunch of models it makes more sense to slice them individually and then union them than try to slice the union. Also fix crash if any of the compound operators gets a `None` model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for new
!slice
,!intersect
,!union
and!difference
nodes in a!canvas3d
scene that cut apart models and combine them with boolean operations. There are some important notes on this:smooth=
andminimum_area=
attributesThis PR re-adds a hard requirement on scipy and introduces new ones on manifold3d, mapbox_earcut, networkx, rtree and shapely.