Skip to content

Commit

Permalink
[hotfix][streaming] Reactive sanity check for windowOperator's mergea…
Browse files Browse the repository at this point in the history
…ble state.
  • Loading branch information
reswqa committed Jul 20, 2023
1 parent 7b9b4e5 commit b332483
Showing 1 changed file with 3 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,10 @@ public long getCurrentProcessingTime() {
// store a typed reference for the state of merging windows - sanity check
if (windowState instanceof InternalMergingState) {
windowMergingState = (InternalMergingState<K, W, IN, ACC, ACC>) windowState;
} else if (windowState != null) {
throw new IllegalStateException(
"The window uses a merging assigner, but the window state is not mergeable.");
}
// TODO this sanity check should be here, but is prevented by an incorrect test (pending
// validation)
// TODO see WindowOperatorTest.testCleanupTimerWithEmptyFoldingStateForSessionWindows()
// TODO activate the sanity check once resolved
// else if (windowState != null) {
// throw new IllegalStateException(
// "The window uses a merging assigner, but the window state is not mergeable.");
// }

@SuppressWarnings("unchecked")
final Class<Tuple2<W, W>> typedTuple = (Class<Tuple2<W, W>>) (Class<?>) Tuple2.class;
Expand Down

0 comments on commit b332483

Please sign in to comment.