Skip to content

Commit

Permalink
cmd/devp2p: lower route53 change limit again (ethereum#20819)
Browse files Browse the repository at this point in the history
  • Loading branch information
fjl authored Mar 26, 2020
1 parent 1583e7d commit 87a411b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions cmd/devp2p/dns_route53.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ import (
"gopkg.in/urfave/cli.v1"
)

// The Route53 limits change sets to this size. DNS changes need to be split
// up into multiple batches to work around the limit.
const route53ChangeLimit = 30000
// Route53 limits change sets to 32k of 'RDATA size'. DNS changes need to be split up into
// multiple batches to work around the limit. Unfortunately I cannot find any
// documentation explaining how the RDATA size of a change set is computed and the best we
// can do is estimate it. For this reason, our internal limit is much lower than 32k.
const route53ChangeLimit = 20000

var (
route53AccessKeyFlag = cli.StringFlag{
Expand Down

0 comments on commit 87a411b

Please sign in to comment.