in-band: Use "internal" netdev type for local ports.

A bridge's local port always has type "internal", so opening it with type "system" can't be correct. This was causing upgrade problems. Specifically, in certain bridge topologies, if there was a manager set force-reload-kmod would fail. This is because the local port netdev would open in the in-band code with type "system", confusing the more important netdev_open() in iface_create(). Bug #15067. Signed-off-by: Ethan Jackson <[email protected]>
jonnary · Feb 25, 2013 · 89e3f9c · 89e3f9c
1 parent 19616e4
commit 89e3f9c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ofproto/in-band.c b/ofproto/in-band.c
@@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char *local_name,
     int error;
 
     *in_bandp = NULL;
-    error = netdev_open(local_name, "system", &local_netdev);
+    error = netdev_open(local_name, "internal", &local_netdev);
     if (error) {
         VLOG_ERR("failed to initialize in-band control: cannot open "
                  "datapath local port %s (%s)", local_name, strerror(error));