Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify non-existent field for combobox #28

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add ability to specify non-existent field for combobox #28

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca1bce9
Add ability to specify non-exist field for combobox
Feb 10, 2024
845964d
Use try instead of respond_to?
Feb 11, 2024
aeaf623
Add mock_form helper
Feb 11, 2024
aa1f93b
Add component tests for hidden_field_attrs method
Feb 11, 2024
5ac36a6
Merge branch 'josefarias:main' into add-ability-to-specify-non-exist-…
pranavbabu Feb 12, 2024
2ac2d10
Update test/presenters/hotwire_combobox/component_test.rb
pranavbabu Feb 12, 2024
ac411b6
Update test/presenters/hotwire_combobox/component_test.rb
pranavbabu Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use try instead of respond_to?
  • Loading branch information
Pranav Babu committed Feb 11, 2024
commit 845964d67264dade45ec647101065e1a4b226d8c
6 changes: 1 addition & 5 deletions app/presenters/hotwire_combobox/component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,7 @@ def hidden_field_data
end

def hidden_field_value
if form&.object&.respond_to?(name)
form.object.public_send(name)
else
value
end
form&.object&.try(name) || value
end


Expand Down