Skip to content

Commit

Permalink
Merge branch 'work.mount3' of git://git.kernel.org/pub/scm/linux/kern…
Browse files Browse the repository at this point in the history
…el/git/viro/vfs

Pull mount fixes from Al Viro:
 "A couple of regressions from the mount series"

* 'work.mount3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  vfs: add missing blkdev_put() in get_tree_bdev()
  shmem: fix LSM options parsing
  • Loading branch information
torvalds committed Oct 10, 2019
2 parents 5e48e55 + 6fcf0c7 commit 015c21b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 4 additions & 1 deletion fs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1300,6 +1300,7 @@ int get_tree_bdev(struct fs_context *fc,
mutex_lock(&bdev->bd_fsfreeze_mutex);
if (bdev->bd_fsfreeze_count > 0) {
mutex_unlock(&bdev->bd_fsfreeze_mutex);
blkdev_put(bdev, mode);
warnf(fc, "%pg: Can't mount, blockdev is frozen", bdev);
return -EBUSY;
}
Expand All @@ -1308,8 +1309,10 @@ int get_tree_bdev(struct fs_context *fc,
fc->sget_key = bdev;
s = sget_fc(fc, test_bdev_super_fc, set_bdev_super_fc);
mutex_unlock(&bdev->bd_fsfreeze_mutex);
if (IS_ERR(s))
if (IS_ERR(s)) {
blkdev_put(bdev, mode);
return PTR_ERR(s);
}

if (s->s_root) {
/* Don't summarily change the RO/RW state. */
Expand Down
6 changes: 6 additions & 0 deletions mm/shmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -3482,6 +3482,12 @@ static int shmem_parse_options(struct fs_context *fc, void *data)
{
char *options = data;

if (options) {
int err = security_sb_eat_lsm_opts(options, &fc->security);
if (err)
return err;
}

while (options != NULL) {
char *this_char = options;
for (;;) {
Expand Down

0 comments on commit 015c21b

Please sign in to comment.