Skip to content

Commit

Permalink
Revert "lib/test_printf.c: call wait_for_random_bytes() before plain …
Browse files Browse the repository at this point in the history
…%p tests"

This reverts commit ee410f1.

It might prevent the machine from boot. It would wait for enough
randomness at the very beginning of kernel_init(). But there is
basically nothing running in parallel that would help to produce
any randomness.

Reported-by: Steven Rostedt (VMware) <[email protected]>
Signed-off-by: Petr Mladek <[email protected]>
  • Loading branch information
pmladek committed Jun 25, 2018
1 parent ce397d2 commit 043f891
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions lib/test_printf.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,6 @@ plain(void)
{
int err;

/*
* Make sure crng is ready. Otherwise we get "(ptrval)" instead
* of a hashed address when printing '%p' in plain_hash() and
* plain_format().
*/
wait_for_random_bytes();

err = plain_hash();
if (err) {
pr_warn("plain 'p' does not appear to be hashed\n");
Expand Down

0 comments on commit 043f891

Please sign in to comment.