Skip to content

Commit

Permalink
dm: add add_disk() error handling
Browse files Browse the repository at this point in the history
We never checked for errors on add_disk() as this function returned
void. Now that this is fixed, use the shiny new error handling.

There are two calls to dm_setup_md_queue() which can fail then, one on
dm_early_create() and we can easily see that the error path there
calls dm_destroy in the error path. The other use case is on the ioctl
table_load case. If that fails userspace needs to call the
DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
failure.

Reviewed-by: Hannes Reinecke <[email protected]>
Signed-off-by: Luis Chamberlain <[email protected]>
Signed-off-by: Mike Snitzer <[email protected]>
  • Loading branch information
mcgrof authored and snitm committed Nov 1, 2021
1 parent ea3dba3 commit 0899753
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -2086,7 +2086,9 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t)
if (r)
return r;

add_disk(md->disk);
r = add_disk(md->disk);
if (r)
return r;

r = dm_sysfs_init(md);
if (r) {
Expand Down

0 comments on commit 0899753

Please sign in to comment.