crypto: algif_aead - Fix kernel panic on list_del

Kernel panics when userspace program try to access AEAD interface. Remove node from Linked List before freeing its memory. Cc: <[email protected]> Signed-off-by: Harsh Jain <[email protected]> Reviewed-by: Stephan Müller <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
josf · Feb 3, 2017 · 0b529f1 · 0b529f1
1 parent c268199
commit 0b529f1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/crypto/algif_aead.c b/crypto/algif_aead.c
@@ -661,9 +661,9 @@ static int aead_recvmsg_sync(struct socket *sock, struct msghdr *msg, int flags)
 unlock:
 	list_for_each_entry_safe(rsgl, tmp, &ctx->list, list) {
 		af_alg_free_sg(&rsgl->sgl);
+		list_del(&rsgl->list);
 		if (rsgl != &ctx->first_rsgl)
 			sock_kfree_s(sk, rsgl, sizeof(*rsgl));
-		list_del(&rsgl->list);
 	}
 	INIT_LIST_HEAD(&ctx->list);
 	aead_wmem_wakeup(sk);