Skip to content

Commit

Permalink
[PATCH] genirq: x86_64 irq: Reenable migrating irqs to other cpus
Browse files Browse the repository at this point in the history
In the latest changes the code for migrating x86_64 irqs was dropped.  This
reads it in a fashion that will work even if we change the vector on level
triggered irqs when we migrate them.

[[email protected]: build fix]
Signed-off-by: Eric W. Biederman <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Rajesh Shah <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: "Protasevich, Natalie" <[email protected]>
Cc: "Luck, Tony" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
ebiederm authored and Linus Torvalds committed Oct 4, 2006
1 parent e7b946e commit 0be6652
Showing 1 changed file with 33 additions and 3 deletions.
36 changes: 33 additions & 3 deletions arch/x86_64/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1254,18 +1254,48 @@ static int ioapic_retrigger_vector(unsigned int vector)
* races.
*/

static void ack_apic(unsigned int vector)
static void ack_apic(unsigned int irq)
{
ack_APIC_irq();
}

static void ack_apic_edge(unsigned int irq)
{
move_native_irq(irq);
ack_APIC_irq();
}

static void ack_apic_level(unsigned int irq)
{
int do_unmask_irq = 0;

#if defined(CONFIG_GENERIC_PENDING_IRQ) || defined(CONFIG_IRQBALANCE)
/* If we are moving the irq we need to mask it */
if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING)) {
do_unmask_irq = 1;
mask_IO_APIC_irq(irq);
}
#endif

/*
* We must acknowledge the irq before we move it or the acknowledge will
* not propogate properly.
*/
ack_APIC_irq();

/* Now we can move and renable the irq */
move_masked_irq(irq);
if (unlikely(do_unmask_irq))
unmask_IO_APIC_irq(irq);
}

static struct irq_chip ioapic_chip __read_mostly = {
.name = "IO-APIC",
.startup = startup_ioapic_vector,
.mask = mask_ioapic_vector,
.unmask = unmask_ioapic_vector,
.ack = ack_apic,
.eoi = ack_apic,
.ack = ack_apic_edge,
.eoi = ack_apic_level,
#ifdef CONFIG_SMP
.set_affinity = set_ioapic_affinity_vector,
#endif
Expand Down

0 comments on commit 0be6652

Please sign in to comment.