Skip to content

Commit

Permalink
udf: Deletion of unnecessary checks before the function call "iput"
Browse files Browse the repository at this point in the history
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
  • Loading branch information
elfring authored and jankara committed Nov 19, 2014
1 parent 11cc9f5 commit 0d454e4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fs/udf/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -2237,8 +2237,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
return 0;

error_out:
if (sbi->s_vat_inode)
iput(sbi->s_vat_inode);
iput(sbi->s_vat_inode);
#ifdef CONFIG_UDF_NLS
if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
unload_nls(sbi->s_nls_map);
Expand Down Expand Up @@ -2291,8 +2290,7 @@ static void udf_put_super(struct super_block *sb)

sbi = UDF_SB(sb);

if (sbi->s_vat_inode)
iput(sbi->s_vat_inode);
iput(sbi->s_vat_inode);
#ifdef CONFIG_UDF_NLS
if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
unload_nls(sbi->s_nls_map);
Expand Down

0 comments on commit 0d454e4

Please sign in to comment.