Skip to content

Commit

Permalink
arm64: dts: ti: k3-j721s2: Enable UART nodes at the board level
Browse files Browse the repository at this point in the history
UART nodes defined in the top-level J721s2 SoC dtsi files are incomplete
and may not be functional unless they are extended with pinmux
information.

As the pinmux is only known at the board integration level, these
nodes should only be enabled when provided with this information.

Disable the UART nodes in the dtsi files and only enable the ones that
are actually pinned out on a given board.

Signed-off-by: Andrew Davis <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
Reviewed-by: Bryan Brattlof <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
glneo authored and nmenon committed Oct 28, 2022
1 parent a9ed915 commit 0e63f35
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 34 deletions.
38 changes: 4 additions & 34 deletions arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
Original file line number Diff line number Diff line change
Expand Up @@ -219,49 +219,19 @@
status = "reserved";
};

&main_uart0 {
status = "disabled";
};

&main_uart1 {
status = "disabled";
};

&main_uart2 {
status = "disabled";
};

&main_uart3 {
status = "disabled";
};

&main_uart4 {
status = "disabled";
};

&main_uart5 {
status = "disabled";
};

&main_uart6 {
status = "disabled";
};

&main_uart7 {
status = "disabled";
&mcu_uart0 {
status = "okay";
/* Default pinmux */
};

&main_uart8 {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_uart8_pins_default>;
/* Shared with TFA on this platform */
power-domains = <&k3_pds 357 TI_SCI_PD_SHARED>;
};

&main_uart9 {
status = "disabled";
};

&main_i2c0 {
clock-frequency = <400000>;

Expand Down
10 changes: 10 additions & 0 deletions arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
clocks = <&k3_clks 146 3>;
clock-names = "fclk";
power-domains = <&k3_pds 146 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart1: serial@2810000 {
Expand All @@ -90,6 +91,7 @@
clocks = <&k3_clks 350 3>;
clock-names = "fclk";
power-domains = <&k3_pds 350 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart2: serial@2820000 {
Expand All @@ -100,6 +102,7 @@
clocks = <&k3_clks 351 3>;
clock-names = "fclk";
power-domains = <&k3_pds 351 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart3: serial@2830000 {
Expand All @@ -110,6 +113,7 @@
clocks = <&k3_clks 352 3>;
clock-names = "fclk";
power-domains = <&k3_pds 352 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart4: serial@2840000 {
Expand All @@ -120,6 +124,7 @@
clocks = <&k3_clks 353 3>;
clock-names = "fclk";
power-domains = <&k3_pds 353 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart5: serial@2850000 {
Expand All @@ -130,6 +135,7 @@
clocks = <&k3_clks 354 3>;
clock-names = "fclk";
power-domains = <&k3_pds 354 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart6: serial@2860000 {
Expand All @@ -140,6 +146,7 @@
clocks = <&k3_clks 355 3>;
clock-names = "fclk";
power-domains = <&k3_pds 355 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart7: serial@2870000 {
Expand All @@ -150,6 +157,7 @@
clocks = <&k3_clks 356 3>;
clock-names = "fclk";
power-domains = <&k3_pds 356 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart8: serial@2880000 {
Expand All @@ -160,6 +168,7 @@
clocks = <&k3_clks 357 3>;
clock-names = "fclk";
power-domains = <&k3_pds 357 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_uart9: serial@2890000 {
Expand All @@ -170,6 +179,7 @@
clocks = <&k3_clks 358 3>;
clock-names = "fclk";
power-domains = <&k3_pds 358 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

main_gpio0: gpio@600000 {
Expand Down
2 changes: 2 additions & 0 deletions arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
clocks = <&k3_clks 359 3>;
clock-names = "fclk";
power-domains = <&k3_pds 359 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

mcu_uart0: serial@40a00000 {
Expand All @@ -101,6 +102,7 @@
clocks = <&k3_clks 149 3>;
clock-names = "fclk";
power-domains = <&k3_pds 149 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};

wkup_gpio0: gpio@42110000 {
Expand Down

0 comments on commit 0e63f35

Please sign in to comment.