s390/ap: function rework based on compiler warning

Slight rework of function __ap_revise_reserved() because of unused variable warning when build with W=1. This patch introduces an additional debug feature warning message when device_reprobe() returns with failure. However, the return value of __ap_revise_reserved() is still hard coded to 0 as this is a callback function to be used together with bus_for_each_dev() and thus the return value indicates to go on with the bus_for_each_dev() loop and not apport on a failure of something within this function. Signed-off-by: Harald Freudenberger <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
josf · Oct 26, 2021 · 132c1e7 · 132c1e7
1 parent ad9a145
commit 132c1e7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
@@ -793,6 +793,9 @@ static int __ap_revise_reserved(struct device *dev, void *dummy)
 			AP_DBF_DBG("%s reprobing queue=%02x.%04x\n",
 				   __func__, card, queue);
 			rc = device_reprobe(dev);
+			if (rc)
+				AP_DBF_WARN("%s reprobing queue=%02x.%04x failed\n",
+					    __func__, card, queue);
 		}
 	}