Skip to content

Commit

Permalink
crypto: cavium/nitrox - Replace GFP_ATOMIC with GFP_KERNEL in crypto_…
Browse files Browse the repository at this point in the history
…alloc_context()

crypto_alloc_context() is only called by nitrox_skcipher_init(), which is
never called in atomic context.

crypto_alloc_context() calls dma_pool_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
XidianGeneral authored and herbertx committed Aug 3, 2018
1 parent 43490e8 commit 1c96dde
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/crypto/cavium/nitrox/nitrox_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ void *crypto_alloc_context(struct nitrox_device *ndev)
void *vaddr;
dma_addr_t dma;

vaddr = dma_pool_alloc(ndev->ctx_pool, (GFP_ATOMIC | __GFP_ZERO), &dma);
vaddr = dma_pool_alloc(ndev->ctx_pool, (GFP_KERNEL | __GFP_ZERO), &dma);
if (!vaddr)
return NULL;

Expand Down

0 comments on commit 1c96dde

Please sign in to comment.