Skip to content

Commit

Permalink
ALSA: powermac: Deletion of an unnecessary check before the function …
Browse files Browse the repository at this point in the history
…call "pci_dev_put"

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
elfring authored and tiwai committed Nov 17, 2014
1 parent c283661 commit 1ea7a56
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sound/ppc/pmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -887,8 +887,7 @@ static int snd_pmac_free(struct snd_pmac *chip)
}
}

if (chip->pdev)
pci_dev_put(chip->pdev);
pci_dev_put(chip->pdev);
of_node_put(chip->node);
kfree(chip);
return 0;
Expand Down

0 comments on commit 1ea7a56

Please sign in to comment.