Skip to content

Commit

Permalink
tools/power/x86/intel-speed-select: Make process_command generic
Browse files Browse the repository at this point in the history
Make the process_command take any help command and command list.  This
will make it easier to help commands and a command list for CascadeLake-N.

Signed-off-by: Prarit Bhargava <[email protected]>
Signed-off-by: Srinivas Pandruvada <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
  • Loading branch information
prarit authored and andy-shev committed Oct 15, 2019
1 parent ce1326a commit 210369d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions tools/power/x86/intel-speed-select/isst-config.c
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,9 @@ static struct process_cmd_help_struct isst_help_cmds[] = {
{ NULL, NULL }
};

void process_command(int argc, char **argv)
void process_command(int argc, char **argv,
struct process_cmd_help_struct *help_cmds,
struct process_cmd_struct *cmds)
{
int i = 0, matched = 0;
char *feature = argv[optind];
Expand All @@ -1827,9 +1829,9 @@ void process_command(int argc, char **argv)

debug_printf("feature name [%s] command [%s]\n", feature, cmd);
if (!strcmp(cmd, "-h") || !strcmp(cmd, "--help")) {
while (isst_help_cmds[i].feature) {
if (!strcmp(isst_help_cmds[i].feature, feature)) {
isst_help_cmds[i].process_fn();
while (help_cmds[i].feature) {
if (!strcmp(help_cmds[i].feature, feature)) {
help_cmds[i].process_fn();
exit(0);
}
++i;
Expand All @@ -1839,11 +1841,11 @@ void process_command(int argc, char **argv)
create_cpu_map();

i = 0;
while (isst_cmds[i].feature) {
if (!strcmp(isst_cmds[i].feature, feature) &&
!strcmp(isst_cmds[i].command, cmd)) {
while (cmds[i].feature) {
if (!strcmp(cmds[i].feature, feature) &&
!strcmp(cmds[i].command, cmd)) {
parse_cmd_args(argc, optind + 1, argv);
isst_cmds[i].process_fn(isst_cmds[i].arg);
cmds[i].process_fn(cmds[i].arg);
matched = 1;
break;
}
Expand Down Expand Up @@ -1964,7 +1966,7 @@ static void cmdline(int argc, char **argv)
if (ret)
goto out;

process_command(argc, argv);
process_command(argc, argv, isst_help_cmds, isst_cmds);
out:
free_cpu_set(present_cpumask);
free_cpu_set(target_cpumask);
Expand Down

0 comments on commit 210369d

Please sign in to comment.