Skip to content

Commit

Permalink
dt-bindings: net: dsa: mediatek,mt7530: make trivial changes
Browse files Browse the repository at this point in the history
Make trivial changes on the binding.

- Update title to include MT7531 switch.
- Add me as a maintainer. List maintainers in alphabetical order by first
name.
- Add description to compatible strings.
- Stretch descriptions up to the 80 character limit.
- Remove lists for single items.
- Remove requiring reg as it's already required by dsa-port.yaml.
- Define acceptable reg values for the CPU ports.
- Remove quotes from $ref: "dsa.yaml#".

Signed-off-by: Arınç ÜNAL <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
arinc9 authored and kuba-moo committed Aug 31, 2022
1 parent 146ecba commit 214537c
Showing 1 changed file with 31 additions and 19 deletions.
50 changes: 31 additions & 19 deletions Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
$id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Mediatek MT7530 Ethernet switch
title: Mediatek MT7530 and MT7531 Ethernet Switches

maintainers:
- Sean Wang <sean.wang@mediatek.com>
- Arınç ÜNAL <arinc.unal@arinc9.com>
- Landen Chao <[email protected]>
- DENG Qingfang <[email protected]>
- Sean Wang <[email protected]>

description: |
Port 5 of mt7530 and mt7621 switch is muxed between:
Expand Down Expand Up @@ -61,10 +62,18 @@ description: |
properties:
compatible:
enum:
- mediatek,mt7530
- mediatek,mt7531
- mediatek,mt7621
oneOf:
- description:
Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC
const: mediatek,mt7530

- description:
Standalone MT7531
const: mediatek,mt7531

- description:
Multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs
const: mediatek,mt7621

reg:
maxItems: 1
Expand All @@ -79,7 +88,7 @@ properties:
gpio-controller:
type: boolean
description:
if defined, MT7530's LED controller will run on GPIO mode.
If defined, MT7530's LED controller will run on GPIO mode.

"#interrupt-cells":
const: 1
Expand All @@ -92,8 +101,8 @@ properties:
io-supply:
description:
Phandle to the regulator node necessary for the I/O power.
See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
for details for the regulator setup on these boards.
See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt for
details for the regulator setup on these boards.

mediatek,mcm:
type: boolean
Expand All @@ -110,8 +119,8 @@ properties:

resets:
description:
Phandle pointing to the system reset controller with line index for
the ethsys.
Phandle pointing to the system reset controller with line index for the
ethsys.
maxItems: 1

patternProperties:
Expand All @@ -128,27 +137,31 @@ patternProperties:
properties:
reg:
description:
Port address described must be 5 or 6 for CPU port and from 0
to 5 for user ports.
Port address described must be 5 or 6 for CPU port and from 0 to 5
for user ports.

allOf:
- $ref: dsa-port.yaml#
- if:
properties:
label:
items:
- const: cpu
const: cpu
then:
required:
- reg
- phy-mode

properties:
reg:
enum:
- 5
- 6

required:
- compatible
- reg

allOf:
- $ref: "dsa.yaml#"
- $ref: dsa.yaml#
- if:
required:
- mediatek,mcm
Expand All @@ -163,8 +176,7 @@ allOf:
- if:
properties:
compatible:
items:
- const: mediatek,mt7530
const: mediatek,mt7530
then:
required:
- core-supply
Expand Down

0 comments on commit 214537c

Please sign in to comment.