Skip to content

Commit

Permalink
i2c: algos: bit: mention our experience about initial states
Browse files Browse the repository at this point in the history
So, if somebody wants to re-implement this in the future, we pinpoint to
a problem case.

Signed-off-by: Wolfram Sang <[email protected]>
Acked-by: Alex Deucher <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
  • Loading branch information
Wolfram Sang authored and Wolfram Sang committed Jun 29, 2018
1 parent 2a2c8ee commit 2173ed0
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/i2c/algos/i2c-algo-bit.c
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
if (bit_adap->getscl == NULL)
adap->quirks = &i2c_bit_quirk_no_clk_stretch;

/*
* We tried forcing SCL/SDA to an initial state here. But that caused a
* regression, sadly. Check Bugzilla #200045 for details.
*/

ret = add_adapter(adap);
if (ret < 0)
return ret;
Expand Down

0 comments on commit 2173ed0

Please sign in to comment.