Skip to content

Commit

Permalink
usb: misc: onboard_usb_hub: Drop obsolete dependency on COMPILE_TEST
Browse files Browse the repository at this point in the history
Since commit 0166dc1 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Cc: Matthias Kaehlcke <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Jean Delvare <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
jdelvare authored and gregkh committed Nov 29, 2022
1 parent ae423ef commit 22683e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/misc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ config BRCM_USB_PINMAP

config USB_ONBOARD_HUB
tristate "Onboard USB hub support"
depends on OF || COMPILE_TEST
depends on OF
help
Say Y here if you want to support discrete onboard USB hubs that
don't require an additional control bus for initialization, but
Expand Down

0 comments on commit 22683e4

Please sign in to comment.