Skip to content

Commit

Permalink
Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/l…
Browse files Browse the repository at this point in the history
…inux/kernel/git/tip/tip

Pull x86 fix from Ingo Molnar:
 "irq-tracing fixlet"

* 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  x86/tracing: Add irq_enter/exit() in smp_trace_reschedule_interrupt()
  • Loading branch information
torvalds committed Jul 10, 2013
2 parents 72c1c2f + 4787c36 commit 23e3a1d
Showing 1 changed file with 18 additions and 11 deletions.
29 changes: 18 additions & 11 deletions arch/x86/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,23 +265,30 @@ void smp_reschedule_interrupt(struct pt_regs *regs)
*/
}

void smp_trace_reschedule_interrupt(struct pt_regs *regs)
static inline void smp_entering_irq(void)
{
ack_APIC_irq();
irq_enter();
}

void smp_trace_reschedule_interrupt(struct pt_regs *regs)
{
/*
* Need to call irq_enter() before calling the trace point.
* __smp_reschedule_interrupt() calls irq_enter/exit() too (in
* scheduler_ipi(). This is OK, since those functions are allowed
* to nest.
*/
smp_entering_irq();
trace_reschedule_entry(RESCHEDULE_VECTOR);
__smp_reschedule_interrupt();
trace_reschedule_exit(RESCHEDULE_VECTOR);
exiting_irq();
/*
* KVM uses this interrupt to force a cpu out of guest mode
*/
}

static inline void call_function_entering_irq(void)
{
ack_APIC_irq();
irq_enter();
}

static inline void __smp_call_function_interrupt(void)
{
generic_smp_call_function_interrupt();
Expand All @@ -290,14 +297,14 @@ static inline void __smp_call_function_interrupt(void)

void smp_call_function_interrupt(struct pt_regs *regs)
{
call_function_entering_irq();
smp_entering_irq();
__smp_call_function_interrupt();
exiting_irq();
}

void smp_trace_call_function_interrupt(struct pt_regs *regs)
{
call_function_entering_irq();
smp_entering_irq();
trace_call_function_entry(CALL_FUNCTION_VECTOR);
__smp_call_function_interrupt();
trace_call_function_exit(CALL_FUNCTION_VECTOR);
Expand All @@ -312,14 +319,14 @@ static inline void __smp_call_function_single_interrupt(void)

void smp_call_function_single_interrupt(struct pt_regs *regs)
{
call_function_entering_irq();
smp_entering_irq();
__smp_call_function_single_interrupt();
exiting_irq();
}

void smp_trace_call_function_single_interrupt(struct pt_regs *regs)
{
call_function_entering_irq();
smp_entering_irq();
trace_call_function_single_entry(CALL_FUNCTION_SINGLE_VECTOR);
__smp_call_function_single_interrupt();
trace_call_function_single_exit(CALL_FUNCTION_SINGLE_VECTOR);
Expand Down

0 comments on commit 23e3a1d

Please sign in to comment.