fix leak in __logfs_create()

if kmalloc fails, we still need to drop the inode, as we do on other failure exits. Signed-off-by: Al Viro <[email protected]>
josf · Aug 9, 2010 · 2562495 · 2562495
1 parent 0e4f6a7
commit 2562495
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/fs/logfs/dir.c b/fs/logfs/dir.c
@@ -434,8 +434,11 @@ static int __logfs_create(struct inode *dir, struct dentry *dentry,
 	int ret;
 
 	ta = kzalloc(sizeof(*ta), GFP_KERNEL);
-	if (!ta)
+	if (!ta) {
+		inode->i_nlink--;
+		iput(inode);
 		return -ENOMEM;
+	}
 
 	ta->state = CREATE_1;
 	ta->ino = inode->i_ino;