fs/binfmt_elf.c:load_elf_binary(): return -EINVAL on zero-length mapp…

…ings load_elf_binary() returns `retval', not `error'. Fixes: a87938b ("fs/binfmt_elf.c: fix bug in loading of PIE binaries") Reported-by: James Hogan <[email protected]> Cc: Michael Davidson <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
josf · May 29, 2015 · 2b1d3ae · 2b1d3ae
1 parent 649b8de
commit 2b1d3ae
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
@@ -918,7 +918,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
 			total_size = total_mapping_size(elf_phdata,
 							loc->elf_ex.e_phnum);
 			if (!total_size) {
-				error = -EINVAL;
+				retval = -EINVAL;
 				goto out_free_dentry;
 			}
 		}