Skip to content

Commit

Permalink
anon_inodes: mark the anon inode private
Browse files Browse the repository at this point in the history
Inotify was switched to use anon_inode instead of its own private filesystem
which only had one inode in commit c44dcc5 "switch inotify_user to
anon_inode"

The problem with this is that now the inotify inode is not a distinct inode
which can be managed by LSMs.  userspace tools which use inotify were allowed
to use the inotify inode but may not have had permission to do read/write type
operations on the anon_inode.  After looking at the anon_inode and its users
it looks like the best solution is to just mark the anon_inode as S_PRIVATE
so the security system will ignore it.

Signed-off-by: Eric Paris <[email protected]>
Acked-by: James Morris <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
eparis authored and torvalds committed Mar 13, 2010
1 parent 83c0fb6 commit 3836a03
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/anon_inodes.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ static struct inode *anon_inode_mkinode(void)
inode->i_mode = S_IRUSR | S_IWUSR;
inode->i_uid = current_fsuid();
inode->i_gid = current_fsgid();
inode->i_flags |= S_PRIVATE;
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
return inode;
}
Expand Down

0 comments on commit 3836a03

Please sign in to comment.