Skip to content

Commit

Permalink
reset: Reorder inline reset_control_get*() wrappers
Browse files Browse the repository at this point in the history
We're about to split the current API into two, where consumers will
be forced to be explicit when requesting reset lines.  The choice
will be to either the call the *_exclusive or *_shared variant
depending on whether they can actually tolorate not being asserted
when that request is made.

The new API will look like this once reorded and complete:

  reset_control_get_exclusive()
  reset_control_get_shared()
  reset_control_get_optional_exclusive()
  reset_control_get_optional_shared()
  of_reset_control_get_exclusive()
  of_reset_control_get_shared()
  of_reset_control_get_exclusive_by_index()
  of_reset_control_get_shared_by_index()
  devm_reset_control_get_exclusive()
  devm_reset_control_get_shared()
  devm_reset_control_get_optional_exclusive()
  devm_reset_control_get_optional_shared()
  devm_reset_control_get_exclusive_by_index()
  devm_reset_control_get_shared_by_index()

Signed-off-by: Lee Jones <[email protected]>
Signed-off-by: Philipp Zabel <[email protected]>
  • Loading branch information
Lee Jones authored and pH5 committed Jun 29, 2016
1 parent 1a695a9 commit 3c35f6e
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions include/linux/reset.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ static inline struct reset_control *__must_check reset_control_get(
return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
}

static inline struct reset_control *reset_control_get_optional(
struct device *dev, const char *id)
{
return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
}

/**
* reset_control_get_shared - Lookup and obtain a shared reference to a
* reset controller.
Expand Down Expand Up @@ -141,6 +135,12 @@ static inline struct reset_control *reset_control_get_shared(
return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 1);
}

static inline struct reset_control *reset_control_get_optional(
struct device *dev, const char *id)
{
return __of_reset_control_get(dev ? dev->of_node : NULL, id, 0, 0);
}

/**
* of_reset_control_get - Lookup and obtain an exclusive reference to a
* reset controller.
Expand Down Expand Up @@ -191,6 +191,21 @@ static inline struct reset_control *__must_check devm_reset_control_get(
return __devm_reset_control_get(dev, id, 0, 0);
}

/**
* devm_reset_control_get_shared - resource managed reset_control_get_shared()
* @dev: device to be reset by the controller
* @id: reset line name
*
* Managed reset_control_get_shared(). For reset controllers returned from
* this function, reset_control_put() is called automatically on driver detach.
* See reset_control_get_shared() for more information.
*/
static inline struct reset_control *devm_reset_control_get_shared(
struct device *dev, const char *id)
{
return __devm_reset_control_get(dev, id, 0, 1);
}

static inline struct reset_control *devm_reset_control_get_optional(
struct device *dev, const char *id)
{
Expand All @@ -212,21 +227,6 @@ static inline struct reset_control *devm_reset_control_get_by_index(
return __devm_reset_control_get(dev, NULL, index, 0);
}

/**
* devm_reset_control_get_shared - resource managed reset_control_get_shared()
* @dev: device to be reset by the controller
* @id: reset line name
*
* Managed reset_control_get_shared(). For reset controllers returned from
* this function, reset_control_put() is called automatically on driver detach.
* See reset_control_get_shared() for more information.
*/
static inline struct reset_control *devm_reset_control_get_shared(
struct device *dev, const char *id)
{
return __devm_reset_control_get(dev, id, 0, 1);
}

/**
* devm_reset_control_get_shared_by_index - resource managed
* reset_control_get_shared
Expand Down

0 comments on commit 3c35f6e

Please sign in to comment.