Skip to content

Commit

Permalink
powerpc/eeh: Drop redundant spinlock initialization
Browse files Browse the repository at this point in the history
slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.

Signed-off-by: Haowen Bai <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
Lotte-Bai authored and mpe committed May 22, 2022
1 parent 57b742a commit 3def164
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/powerpc/platforms/pseries/eeh_pseries.c
Original file line number Diff line number Diff line change
Expand Up @@ -847,8 +847,7 @@ static int __init eeh_pseries_init(void)
return -EINVAL;
}

/* Initialize error log lock and size */
spin_lock_init(&slot_errbuf_lock);
/* Initialize error log size */
eeh_error_buf_size = rtas_token("rtas-error-log-max");
if (eeh_error_buf_size == RTAS_UNKNOWN_SERVICE) {
pr_info("%s: unknown EEH error log size\n",
Expand Down

0 comments on commit 3def164

Please sign in to comment.