Skip to content

Commit

Permalink
[PATCH] IOC3/IOC4: PCI mem space resources
Browse files Browse the repository at this point in the history
The SGI IOC3 and IOC4 PCI devices implement memory space apertures, not I/O
space apertures.  Use the appropriate region management functions.

Signed-off-by: Brent Casavant <[email protected]>
Cc: Pat Gefre <[email protected]>
Cc: Stanislaw Skowronek <[email protected]>
Cc: Brent Casavant <[email protected]>
Acked-by: Ralf Baechle <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Brent Casavant authored and Linus Torvalds committed Feb 11, 2007
1 parent 24fa509 commit 52c9ae0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions drivers/misc/ioc4.c
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ ioc4_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
ret = -ENODEV;
goto out_pci;
}
if (!request_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs),
if (!request_mem_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs),
"ioc4_misc")) {
printk(KERN_WARNING
"%s: Unable to request IOC4 misc region "
Expand Down Expand Up @@ -379,7 +379,7 @@ ioc4_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
return 0;

out_misc_region:
release_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs));
release_mem_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs));
out_pci:
kfree(idd);
out_idd:
Expand Down Expand Up @@ -418,7 +418,7 @@ ioc4_remove(struct pci_dev *pdev)
"Device removal may be incomplete.\n",
__FUNCTION__, pci_name(idd->idd_pdev));
}
release_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs));
release_mem_region(idd->idd_bar0, sizeof(struct ioc4_misc_regs));

/* Disable IOC4 and relinquish */
pci_disable_device(pdev);
Expand Down
6 changes: 3 additions & 3 deletions drivers/serial/ioc4_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -2685,7 +2685,7 @@ static int ioc4_serial_remove_one(struct ioc4_driver_data *idd)
free_irq(control->ic_irq, soft);
if (soft->is_ioc4_serial_addr) {
iounmap(soft->is_ioc4_serial_addr);
release_region((unsigned long)
release_mem_region((unsigned long)
soft->is_ioc4_serial_addr,
sizeof(struct ioc4_serial));
}
Expand Down Expand Up @@ -2790,7 +2790,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd)
/* request serial registers */
tmp_addr1 = idd->idd_bar0 + IOC4_SERIAL_OFFSET;

if (!request_region(tmp_addr1, sizeof(struct ioc4_serial),
if (!request_mem_region(tmp_addr1, sizeof(struct ioc4_serial),
"sioc4_uart")) {
printk(KERN_WARNING
"ioc4 (%p): unable to get request region for "
Expand Down Expand Up @@ -2889,7 +2889,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd)
out2:
if (serial)
iounmap(serial);
release_region(tmp_addr1, sizeof(struct ioc4_serial));
release_mem_region(tmp_addr1, sizeof(struct ioc4_serial));
out1:

return ret;
Expand Down
6 changes: 3 additions & 3 deletions drivers/sn/ioc3.c
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ static int ioc3_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
ret = -ENODEV;
goto out_pci;
}
if (!request_region(idd->pma, IOC3_PCI_SIZE, "ioc3")) {
if (!request_mem_region(idd->pma, IOC3_PCI_SIZE, "ioc3")) {
printk(KERN_WARNING
"%s: Unable to request IOC3 region "
"for pci_dev %s.\n",
Expand Down Expand Up @@ -744,7 +744,7 @@ static int ioc3_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
return 0;

out_misc_region:
release_region(idd->pma, IOC3_PCI_SIZE);
release_mem_region(idd->pma, IOC3_PCI_SIZE);
out_pci:
kfree(idd);
out_idd:
Expand Down Expand Up @@ -785,7 +785,7 @@ static void ioc3_remove(struct pci_dev *pdev)
if(idd->dual_irq)
free_irq(idd->irq_eth, (void *)idd);
iounmap(idd->vma);
release_region(idd->pma, IOC3_PCI_SIZE);
release_mem_region(idd->pma, IOC3_PCI_SIZE);

/* Disable IOC3 and relinquish */
pci_disable_device(pdev);
Expand Down

0 comments on commit 52c9ae0

Please sign in to comment.