scsi: virtio_scsi: Add validation for residual bytes from response

This ensures that the residual bytes in response (might come from an untrusted device) will not exceed the data buffer length. Link: https://lore.kernel.org/r/[email protected] Acked-by: Jason Wang <[email protected]> Signed-off-by: Xie Yongji <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
josf · Jun 29, 2021 · 5f638e5 · 5f638e5
1 parent 7df47cd
commit 5f638e5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
@@ -97,7 +97,7 @@ static inline struct Scsi_Host *virtio_scsi_host(struct virtio_device *vdev)
 static void virtscsi_compute_resid(struct scsi_cmnd *sc, u32 resid)
 {
 	if (resid)
-		scsi_set_resid(sc, resid);
+		scsi_set_resid(sc, min(resid, scsi_bufflen(sc)));
 }
 
 /*