Skip to content

Commit

Permalink
[media] cx23885: uninitialized variable in cx23885_av_work_handler()
Browse files Browse the repository at this point in the history
The "handled" variable could be uninitialized if the
interrupt_service_routine() call back hasn't been implimented or if it
has been implemented but doesn't initialize "handled" to zero at the
start.  For example, adv76xx_isr() only sets "handled" to true.

Fixes: 44b153c ('[media] m5mols: Add ISO sensitivity controls')

Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
Dan Carpenter authored and mchehab committed Apr 13, 2016
1 parent e4bccad commit 60587bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/pci/cx23885/cx23885-av.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ void cx23885_av_work_handler(struct work_struct *work)
{
struct cx23885_dev *dev =
container_of(work, struct cx23885_dev, cx25840_work);
bool handled;
bool handled = false;

v4l2_subdev_call(dev->sd_cx25840, core, interrupt_service_routine,
PCI_MSK_AV_CORE, &handled);
Expand Down

0 comments on commit 60587bd

Please sign in to comment.