Skip to content

Commit

Permalink
powerpc/perf: Add support for caps under sysfs in powerpc
Browse files Browse the repository at this point in the history
Add caps support under "/sys/bus/event_source/devices/<pmu>/"
for powerpc. This directory can be used to expose some of the
specific features that powerpc PMU supports to the user.
Example: pmu_name. The name of PMU registered will depend on
platform, say power9 or power10 or it could be Generic Compat
PMU.

Currently the only way to know which is the registered
PMU is from the dmesg logs. But clearing the dmesg will make it
difficult to know exact PMU backend used. And even extracting
from dmesg will be complicated, as we need  to parse the dmesg
logs and add filters for pmu name. Whereas by exposing it via
caps will make it easy as we just need to directly read it from
the sysfs.

Add a caps directory to /sys/bus/event_source/devices/cpu/
for power8, power9, power10 and generic compat PMU in respective
PMU driver code. Update the pmu_name file under caps folder
in core-book3s using "attr_update".

The information exposed currently:
 - pmu_name : Underlying PMU name from the driver

Example result with power9 pmu:

 # ls /sys/bus/event_source/devices/cpu/caps
pmu_name

 # cat /sys/bus/event_source/devices/cpu/caps/pmu_name
POWER9

Signed-off-by: Athira Rajeev <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
athira-rajeev authored and mpe committed Jul 18, 2022
1 parent 78988b2 commit 6320e69
Show file tree
Hide file tree
Showing 5 changed files with 71 additions and 0 deletions.
31 changes: 31 additions & 0 deletions arch/powerpc/perf/core-book3s.c
Original file line number Diff line number Diff line change
Expand Up @@ -2483,6 +2483,33 @@ static int power_pmu_prepare_cpu(unsigned int cpu)
return 0;
}

static ssize_t pmu_name_show(struct device *cdev,
struct device_attribute *attr,
char *buf)
{
if (ppmu)
return sysfs_emit(buf, "%s", ppmu->name);

return 0;
}

static DEVICE_ATTR_RO(pmu_name);

static struct attribute *pmu_caps_attrs[] = {
&dev_attr_pmu_name.attr,
NULL
};

static const struct attribute_group pmu_caps_group = {
.name = "caps",
.attrs = pmu_caps_attrs,
};

static const struct attribute_group *pmu_caps_groups[] = {
&pmu_caps_group,
NULL,
};

int __init register_power_pmu(struct power_pmu *pmu)
{
if (ppmu)
Expand All @@ -2493,6 +2520,10 @@ int __init register_power_pmu(struct power_pmu *pmu)
pmu->name);

power_pmu.attr_groups = ppmu->attr_groups;

if (ppmu->flags & PPMU_ARCH_207S)
power_pmu.attr_update = pmu_caps_groups;

power_pmu.capabilities |= (ppmu->capabilities & PERF_PMU_CAP_EXTENDED_REGS);

#ifdef MSR_HV
Expand Down
10 changes: 10 additions & 0 deletions arch/powerpc/perf/generic-compat-pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,19 @@ static const struct attribute_group generic_compat_pmu_format_group = {
.attrs = generic_compat_pmu_format_attr,
};

static struct attribute *generic_compat_pmu_caps_attrs[] = {
NULL
};

static struct attribute_group generic_compat_pmu_caps_group = {
.name = "caps",
.attrs = generic_compat_pmu_caps_attrs,
};

static const struct attribute_group *generic_compat_pmu_attr_groups[] = {
&generic_compat_pmu_format_group,
&generic_compat_pmu_events_group,
&generic_compat_pmu_caps_group,
NULL,
};

Expand Down
10 changes: 10 additions & 0 deletions arch/powerpc/perf/power10-pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,15 @@ static const struct attribute_group power10_pmu_format_group = {
.attrs = power10_pmu_format_attr,
};

static struct attribute *power10_pmu_caps_attrs[] = {
NULL
};

static struct attribute_group power10_pmu_caps_group = {
.name = "caps",
.attrs = power10_pmu_caps_attrs,
};

static const struct attribute_group *power10_pmu_attr_groups_dd1[] = {
&power10_pmu_format_group,
&power10_pmu_events_group_dd1,
Expand All @@ -267,6 +276,7 @@ static const struct attribute_group *power10_pmu_attr_groups_dd1[] = {
static const struct attribute_group *power10_pmu_attr_groups[] = {
&power10_pmu_format_group,
&power10_pmu_events_group,
&power10_pmu_caps_group,
NULL,
};

Expand Down
10 changes: 10 additions & 0 deletions arch/powerpc/perf/power8-pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,19 @@ static const struct attribute_group power8_pmu_events_group = {
.attrs = power8_events_attr,
};

static struct attribute *power8_pmu_caps_attrs[] = {
NULL
};

static struct attribute_group power8_pmu_caps_group = {
.name = "caps",
.attrs = power8_pmu_caps_attrs,
};

static const struct attribute_group *power8_pmu_attr_groups[] = {
&isa207_pmu_format_group,
&power8_pmu_events_group,
&power8_pmu_caps_group,
NULL,
};

Expand Down
10 changes: 10 additions & 0 deletions arch/powerpc/perf/power9-pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,19 @@ static const struct attribute_group power9_pmu_format_group = {
.attrs = power9_pmu_format_attr,
};

static struct attribute *power9_pmu_caps_attrs[] = {
NULL
};

static struct attribute_group power9_pmu_caps_group = {
.name = "caps",
.attrs = power9_pmu_caps_attrs,
};

static const struct attribute_group *power9_pmu_attr_groups[] = {
&power9_pmu_format_group,
&power9_pmu_events_group,
&power9_pmu_caps_group,
NULL,
};

Expand Down

0 comments on commit 6320e69

Please sign in to comment.