[PATCH] Fix module refcount leak in __set_personality()

If the change of personality does not lead to change of exec domain, __set_personality() returned without releasing the module reference acquired by lookup_exec_domain(). Signed-off-by: Sergey Vlasov <[email protected]> Cc: Christoph Hellwig <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
josf · Mar 24, 2006 · 6a4d11c · 6a4d11c
1 parent b5a7c4f
commit 6a4d11c
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/kernel/exec_domain.c b/kernel/exec_domain.c
@@ -140,6 +140,7 @@ __set_personality(u_long personality)
 	ep = lookup_exec_domain(personality);
 	if (ep == current_thread_info()->exec_domain) {
 		current->personality = personality;
+		module_put(ep->module);
 		return 0;
 	}