Skip to content

Commit

Permalink
spi: Merge spi_controller.{slave,target}_abort()
Browse files Browse the repository at this point in the history
Mixing SPI slave/target handlers and SPI slave/target controllers using
legacy and modern naming does not work well: there are now two different
callbacks for aborting a slave/target operation, of which only one is
populated, while spi_{slave,target}_abort() check and use only one,
which may be the unpopulated one.

Fix this by merging the slave/target abort callbacks into a single
callback using a union, like is already done for the slave/target flags.

Fixes: b8d3b05 ("spi: introduce new helpers with using modern naming")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Link: https://lore.kernel.org/r/809c82d54b85dd87ef7ee69fc93016085be85cec.1667555967.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
geertu authored and broonie committed Nov 4, 2022
1 parent d82316d commit 6c6871c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions include/linux/spi/spi.h
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,10 @@ struct spi_controller {
struct spi_message *message);
int (*unprepare_message)(struct spi_controller *ctlr,
struct spi_message *message);
int (*slave_abort)(struct spi_controller *ctlr);
int (*target_abort)(struct spi_controller *ctlr);
union {
int (*slave_abort)(struct spi_controller *ctlr);
int (*target_abort)(struct spi_controller *ctlr);
};

/*
* These hooks are for drivers that use a generic implementation
Expand Down

0 comments on commit 6c6871c

Please sign in to comment.