printk: drop redundant devkmsg_log_str memsets

We copy in null terminated strings "on" and "off", no need to zero out devkmsg_log_str in control_devkmsg(). Link: http://lkml.kernel.org/r/[email protected] Cc: [email protected] Signed-off-by: Sergey Senozhatsky <[email protected]> Reviewed-by: Steven Rostedt (VMware) <[email protected]> Signed-off-by: Petr Mladek <[email protected]>
josf · Jan 22, 2018 · 6fd78a1 · 6fd78a1
1 parent cca10d5
commit 6fd78a1
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
@@ -131,13 +131,10 @@ static int __init control_devkmsg(char *str)
 	/*
 	 * Set sysctl string accordingly:
 	 */
-	if (devkmsg_log == DEVKMSG_LOG_MASK_ON) {
-		memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE);
-		strncpy(devkmsg_log_str, "on", 2);
-	} else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF) {
-		memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE);
-		strncpy(devkmsg_log_str, "off", 3);
-	}
+	if (devkmsg_log == DEVKMSG_LOG_MASK_ON)
+		strcpy(devkmsg_log_str, "on");
+	else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF)
+		strcpy(devkmsg_log_str, "off");
 	/* else "ratelimit" which is set by default. */
 
 	/*