Skip to content

Commit

Permalink
FRV: Be (self-)consistent and use CONFIG_GDB_CONSOLE everywhere
Browse files Browse the repository at this point in the history
Be (self-)consistent and use CONFIG_GDB_CONSOLE everywhere rather than using
CONFIG_GDBSTUB_CONSOLE in some places and not others.  This is also then
consistent with other archs.

Also remove the gdbstub console device() op which doesn't seem to be necessary
now (especially as it doesn't compile).

[Found by Robert P. J. Day <[email protected]>]

Signed-off-by: David Howells <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
dhowells authored and Linus Torvalds committed Jul 16, 2007
1 parent c1a39e0 commit 7692591
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions arch/frv/kernel/gdb-stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -647,17 +647,11 @@ void debug_to_serial(const char *p, int n)
}
#endif

#ifdef CONFIG_GDBSTUB_CONSOLE

static kdev_t gdbstub_console_dev(struct console *con)
{
return MKDEV(1,3); /* /dev/null */
}
#ifdef CONFIG_GDB_CONSOLE

static struct console gdbstub_console = {
.name = "gdb",
.write = gdbstub_console_write, /* in break.S */
.device = gdbstub_console_dev,
.flags = CON_PRINTBUFFER,
.index = -1,
};
Expand Down Expand Up @@ -2021,7 +2015,7 @@ void __init gdbstub_init(void)
ptr = mem2hex(gdbstub_banner, ptr, sizeof(gdbstub_banner) - 1, 0);
gdbstub_send_packet(output_buffer);
#endif
#if defined(CONFIG_GDBSTUB_CONSOLE) && defined(CONFIG_GDBSTUB_IMMEDIATE)
#if defined(CONFIG_GDB_CONSOLE) && defined(CONFIG_GDBSTUB_IMMEDIATE)
register_console(&gdbstub_console);
#endif

Expand All @@ -2031,7 +2025,7 @@ void __init gdbstub_init(void)
/*
* register the console at a more appropriate time
*/
#if defined (CONFIG_GDBSTUB_CONSOLE) && !defined(CONFIG_GDBSTUB_IMMEDIATE)
#if defined (CONFIG_GDB_CONSOLE) && !defined(CONFIG_GDBSTUB_IMMEDIATE)
static int __init gdbstub_postinit(void)
{
printk("registering console\n");
Expand Down

0 comments on commit 7692591

Please sign in to comment.