Skip to content

Commit

Permalink
mm: Fix comment before truncate_setsize()
Browse files Browse the repository at this point in the history
XFS doesn't always hold i_mutex when calling truncate_setsize() and it
uses a different lock to serialize truncates and writes. So fix the
comment before truncate_setsize().

Reported-by: Jan Beulich <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
Signed-off-by: Dave Chinner <[email protected]>
  • Loading branch information
jankara authored and dchinner committed Nov 6, 2014
1 parent 5d11fb4 commit 77783d0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions mm/truncate.c
Original file line number Diff line number Diff line change
Expand Up @@ -715,8 +715,9 @@ EXPORT_SYMBOL(truncate_pagecache);
* necessary) to @newsize. It will be typically be called from the filesystem's
* setattr function when ATTR_SIZE is passed in.
*
* Must be called with inode_mutex held and before all filesystem specific
* block truncation has been performed.
* Must be called with a lock serializing truncates and writes (generally
* i_mutex but e.g. xfs uses a different lock) and before all filesystem
* specific block truncation has been performed.
*/
void truncate_setsize(struct inode *inode, loff_t newsize)
{
Expand Down

0 comments on commit 77783d0

Please sign in to comment.